Messages in this thread | | | Date | Mon, 1 Nov 2010 10:43:10 -0700 | From | Greg KH <> | Subject | Re: [PATCH 03/10] staging: hv: Convert camel cased struct fields in hv.h to lower cases |
| |
On Mon, Nov 01, 2010 at 09:53:45AM -0700, Haiyang Zhang wrote: > From: Haiyang Zhang <haiyangz@microsoft.com> > > Convert camel cased struct fields in hv.h to lower cases > > Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com> > Signed-off-by: Hank Janssen <hjanssen@microsoft.com>
Why did I get two different copies of some of these patches? Are they different?
> /* The one and only */ > -struct hv_context gHvContext = { > - .SynICInitialized = false, > - .HypercallPage = NULL, > - .SignalEventParam = NULL, > - .SignalEventBuffer = NULL, > +struct hv_context g_hv_context = {
What is the "g_" for? Why are you keeping the unneeded, and unwanted hungarian notation around? Please don't do that.
thanks,
greg k-h
| |