Messages in this thread | | | Date | Mon, 01 Nov 2010 08:51:26 -0700 (PDT) | Subject | Re: All Applied micro boards are failing with current mainline kernel | From | David Miller <> |
| |
From: Josh Boyer <jwboyer@gmail.com> Date: Mon, 1 Nov 2010 11:39:47 -0400
> On Mon, Nov 1, 2010 at 11:36 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote: >> Hi Josh, >> >> On Mon, 1 Nov 2010 11:05:53 -0400 Josh Boyer <jwboyer@gmail.com> wrote: >>> >>> A few hints would be appreciated. >> >> Remove the call to netif_stop_queue() from emac_probe(). Apparently, >> calling this before register_netdev() is now wrong (maybe always was). > > Yeah, I just discovered that myself. I'm wondering > > 1) why we do that in that function?
Because likely it was blindly copied from some other driver.
> 2) If it needs to be removed entirely, or moved to after the > register_netdev call
Removed entirely.
> 3) If the call to netif_carrier_off also needs similar attention.
Not really.
> I can whip up a patch to remove those calls or move them after the > register, but I don't want to do that without knowing which one is > "right".
I've already taken care of this. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |