lkml.org 
[lkml]   [2010]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH RFC] tun: remove of user-controlled memory allocation
    From
    From: "Michael S. Tsirkin" <mst@redhat.com>
    Date: Mon, 1 Nov 2010 10:27:49 +0200

    > Untested, this is just an RFC.
    >
    > tun does a kmalloc where userspace controls the length. This will
    > produce warnings in kernel log when the length is too large, or might
    > block for a long while. A simple fix is to avoid the allocatiuon
    > altogether, and copy from user in a loop.
    >
    > However, with this patch an illegal address passed to the ioctl might
    > leave the filter disabled. Is this something we care about? If
    > yes we could recover by creating a copy of the filter. Thoughts?
    >
    > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

    I think the key issue in situations like this is simply to make
    sure that reasonable things that worked before, still do afterwards.

    And I think your patch does that, so it's fine as far as I can tell.


    \
     
     \ /
      Last update: 2010-11-01 15:19    [W:3.153 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site