lkml.org 
[lkml]   [2009]   [Sep]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 04/33] fs: brlock vfsmount_lock
On Fri, Sep 04, 2009 at 05:19:09PM +0200, Jens Axboe wrote:
> On Fri, Sep 04 2009, npiggin@suse.de wrote:
> > Index: linux-2.6/fs/namei.c
> > ===================================================================
> > --- linux-2.6.orig/fs/namei.c
> > +++ linux-2.6/fs/namei.c
> > @@ -679,15 +679,16 @@ int follow_up(struct path *path)
> > {
> > struct vfsmount *parent;
> > struct dentry *mountpoint;
> > - spin_lock(&vfsmount_lock);
> > +
> > + vfsmount_read_unlock();
> > parent = path->mnt->mnt_parent;
> > if (parent == path->mnt) {
> > - spin_unlock(&vfsmount_lock);
> > + vfsmount_read_unlock();
> > return 0;
>
> Hmm, that looks a bit off.

Thanks Jens, good catch. Yes I haven't actually even tested NFS or
NFSD yet, which I should do soon because they do some interesting
things with the dcache.


\
 
 \ /
  Last update: 2009-09-07 09:41    [W:0.404 / U:26.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site