Messages in this thread Patch in this message | ![/](/images/icornerl.gif) | | Date | Mon, 7 Sep 2009 14:02:47 -0700 (PDT) | From | Linus Torvalds <> | Subject | [PATCH 2/8] Simplify exec_permission_lite() logic |
| |
From: Linus Torvalds <torvalds@linux-foundation.org> Date: Fri, 28 Aug 2009 10:50:37 -0700
Instead of returning EAGAIN and having the caller do something special for that case, just do the special case directly.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> --- fs/namei.c | 5 +---- 1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/fs/namei.c b/fs/namei.c index 164aa15..bf8aa95 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -435,7 +435,7 @@ static int exec_permission_lite(struct inode *inode) umode_t mode = inode->i_mode; if (inode->i_op->permission) - return -EAGAIN; + return inode_permission(inode, MAY_EXEC); if (current_fsuid() == inode->i_uid) mode >>= 6; @@ -853,9 +853,6 @@ static int __link_path_walk(const char *name, struct nameidata *nd) nd->flags |= LOOKUP_CONTINUE; err = exec_permission_lite(inode); - if (err == -EAGAIN) - err = inode_permission(nd->path.dentry->d_inode, - MAY_EXEC); if (err) break; -- 1.6.4.1.209.g74b8
| ![\](/images/icornerr.gif) |