Messages in this thread | | | Subject | Re: [PATCH 6/9] drivers/media/video/uvc: Use %pUr to print UUIDs | From | Joe Perches <> | Date | Wed, 30 Sep 2009 17:24:10 -0700 |
| |
On Thu, 2009-10-01 at 02:20 +0200, Laurent Pinchart wrote: > > flags = info->flags; > > if (((flags & UVC_CONTROL_GET_CUR) && !(inf & (1 << 0))) || > > ((flags & UVC_CONTROL_SET_CUR) && !(inf & (1 << 1)))) { > > - uvc_trace(UVC_TRACE_CONTROL, "Control " > > - UVC_GUID_FORMAT "/%u flags don't match " > > - "supported operations.\n", > > - UVC_GUID_ARGS(info->entity), info->selector); > > + uvc_trace(UVC_TRACE_CONTROL, > > + "Control %pUr/%u flags don't match supported operations.\n", > > + info->entity, info->selector); > > This doesn't fit the 80 columns limit. Please run checkpatch.pl on your patches.
Intentional. Strings shouldn't be broken across lines unnecessarily.
> > snprintf(format->name, sizeof format->name, > > - UVC_GUID_FORMAT, UVC_GUID_ARGS(&buffer[5])); > > + "%pUr", &Buffer[5]); > > Should be &buffer[5], not &Buffer[5]. You haven't compiled the patch, have > you ? :-)
Unintentional. Did compile allyesconfig.
cheers, Joe
| |