Messages in this thread | | | Subject | Re: [PATCH 1/2] net/netfilter/ipvs: Move #define KMSG_COMPONENT to Makefile | From | Joe Perches <> | Date | Wed, 30 Sep 2009 16:09:20 -0700 |
| |
On Thu, 2009-10-01 at 00:46 +0200, Jan Engelhardt wrote: > On Thursday 2009-10-01 00:37, Joe Perches wrote: > >This centralizes the definition and removes the > >replicated #defines from all files > And increases the length of the command line. Not that Linux does not > support long command lines (in fact, configure often determines huge > possible values on the max length test), but sometimes, developers > have to inspect the command lines anyway for bugs, or something. It > is already pretty long due to all the compiler flags.
Hi Jan.
I think this increased command line length hardly matters.
I think a reasonable complaint might be that it separates the definition of a macro from the code. I think it's similar to the already used KBUILD_MODNAME macro though.
> How about an #include file for the ipvs private things?
It's not just IPVS, this style could be used treewide without requiring extra #includes.
cheers, Joe
| |