Messages in this thread | | | Date | Wed, 30 Sep 2009 08:55:33 +0200 | From | Sam Ravnborg <> | Subject | Re: [RFC] move #define pr_fmt KBUILD_MODNAME and KMSG_COMPONENT to Makefiles? |
| |
Hi Joe.
On Tue, Sep 29, 2009 at 11:15:04AM -0700, Joe Perches wrote: > There are starting to be more uses of > > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > > and > > #define KMSG_COMPONENT "foo" > #define pr_fmt(fmt) KMSG_COMPONENT ": " fmt > > in kernel sources. > > Perhaps it would be better to put these > defines in the appropriate Makefile and not > sprinkle the sources with them multiple times?
Maybe I'm a bit dense but I do not quiete follow you here. What is it you want moved to kbuild here?
To me it looks more like a logical extension to the pr_* macros based on info we already have available.
Sam
| |