Messages in this thread | | | Date | Wed, 30 Sep 2009 17:33:01 +0200 | Subject | Re: [PATCH] ipvs: Add boundary check on ioctl arguments | From | Hannes Eder <> |
| |
On Wed, Sep 30, 2009 at 17:18, Arjan van de Ven <arjan@infradead.org> wrote: > On Wed, 30 Sep 2009 15:38:12 +0200 > Hannes Eder <heder@google.com> wrote: >> > @@ -2353,17 +2357,25 @@ do_ip_vs_get_ctl(struct sock *sk, int cmd, >> > void __user >> *user, int *len) >> > { >> > unsigned char arg[128]; >> >> can MAX_ARG_LEN be used here? > > I am not convinced... it is a different numerical value, > so it could be an ABI change. Rather not do that in this > type of patch...
For do_ip_vs_set_ctl MAX_ARG_LEN is used:
static int do_ip_vs_set_ctl(struct sock *sk, int cmd, void __user *user, unsigned int len) { int ret; unsigned char arg[MAX_ARG_LEN]; ...
I assume that will be fine for do_ip_vs_get_ctl as well.
-Hannes -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |