lkml.org 
[lkml]   [2009]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [origin tree boot hang] [PATCH] Revert "early_printk:Allowmorethan one early console"


On Wed, 23 Sep 2009, Jason Wessel wrote:
>
> Perhaps you will consider adding this patch to your tree? It fixes the
> specific case you mentioned. It will still allow the board to boot and
> instead of crashing, print a warning on the second instance.

Ugh. This looks totally bogus.

Why don't you just add CON_REGISTERED to the console flags, and do

/* Already registered? */
if (early_console->flags & CON_REGISTERED)
return;
early_console->flags |= CON_REGISTERED;

there instead? That whole "loop over existing consoles to check their
names" looks silly and broken, and you're already playing with the flags
in there (CON_BOOT).

Linus


\
 
 \ /
  Last update: 2009-10-18 23:28    [W:0.298 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site