lkml.org 
[lkml]   [2009]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [GIT PULL] xen: Check NX state before setting up GDT mapping

* Jeremy Fitzhardinge <jeremy@goop.org> wrote:

> On 09/23/09 05:36, Ingo Molnar wrote:
> >> +#ifdef CONFIG_X86_64
> >> + /* Work out if we support NX */
> >> + check_efer();
> >> +#endif
> >> +
> >>
> > btw., this #ifdef could sure be eliminated, right?
> >
>
> check_efer() is only defined on x86-64 and all its existing callsites
> have a similar #ifdef.

Yes, a familar pattern that prompted my comment.

> [...] NX setup is an area which could do with a bit of hitting with
> the unification stick.

Yes.

Ingo


\
 
 \ /
  Last update: 2009-09-23 21:15    [W:0.059 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site