Messages in this thread | | | Date | Wed, 23 Sep 2009 21:13:15 +0200 | From | Ingo Molnar <> | Subject | Re: [GIT PULL] xen: Check NX state before setting up GDT mapping |
| |
* Jeremy Fitzhardinge <jeremy@goop.org> wrote:
> On 09/23/09 05:36, Ingo Molnar wrote: > >> +#ifdef CONFIG_X86_64 > >> + /* Work out if we support NX */ > >> + check_efer(); > >> +#endif > >> + > >> > > btw., this #ifdef could sure be eliminated, right? > > > > check_efer() is only defined on x86-64 and all its existing callsites > have a similar #ifdef.
Yes, a familar pattern that prompted my comment.
> [...] NX setup is an area which could do with a bit of hitting with > the unification stick.
Yes.
Ingo
| |