lkml.org 
[lkml]   [2009]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC][PATCH] SCHED_EDF scheduling class
From
Date
On Wed, 2009-09-23 at 14:25 +0200, Ingo Molnar wrote:
> * Avi Kivity <avi@redhat.com> wrote:
>
> >> discouraging contributions is more something that happens when you
> >> get the responses I got earlier in this thread..
> >
> > That's probably intentional. Whitespace fixes have their place but
> > not at this stage in a patch's lifecycle.
>
> Exactly. What might make sense is to scan linux-next for new commits
> that show serious cleanliness trouble - and send fix patches to the
> parties involved. That's a real effort and brings the code forward.

Often times when a patch is at youngest that when you want to catch
these issues .. This EDF patch will likely get submitted more than
twice. If you catch all the minor problems first you will not be dealing
with them later when it comes time to include the code.

In this case the author is not totally aware of how to submit this
code.. I don't think it's at all inappropriate to comment on that. His
next submission will likely be much cleaner and nicer. It may even speed
up the inclusion process since he'll be more easily able to submit the
code (with practice and comments from us).

Daniel





\
 
 \ /
  Last update: 2009-09-23 16:53    [W:0.090 / U:0.184 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site