Messages in this thread | | | Date | Wed, 23 Sep 2009 12:19:21 +0200 | From | Mikael Pettersson <> | Subject | Re: [RFC Patch] kbuild: remove -Wdeclaration-after-statement |
| |
Amerigo Wang writes: > > I got lots of "ISO C90 forbids mixed declarations and code" warnings > during compile today's kernel. > > I think we can remove the gcc option '-Wdeclaration-after-statement' > now, since we already have C99 for 10 years. :) > > Signed-off-by: WANG Cong <amwang@redhat.com> > Cc: Sam Ravnborg <sam@ravnborg.org> > > --- > diff --git a/Makefile b/Makefile > index 433493a..038bda2 100644 > --- a/Makefile > +++ b/Makefile > @@ -559,9 +559,6 @@ endif > NOSTDINC_FLAGS += -nostdinc -isystem $(shell $(CC) -print-file-name=include) > CHECKFLAGS += $(NOSTDINC_FLAGS) > > -# warn about C99 declaration after statement > -KBUILD_CFLAGS += $(call cc-option,-Wdeclaration-after-statement,) > - > # disable pointer signed / unsigned warnings in gcc 4.0 > KBUILD_CFLAGS += $(call cc-option,-Wno-pointer-sign,)
This is more a matter of coding-style policy than C technicalities.
I happen to hate declarations at random places in the code, so I'd prefer the offending code to be fixed instead.
| |