Messages in this thread | ![/](/images/icornerl.gif) | | Subject | Re: [patch] Re: [perf] Finding uninstalled modules Was Re: mailing list for trace users | From | Mike Galbraith <> | Date | Wed, 23 Sep 2009 12:02:39 +0200 |
| |
On Wed, 2009-09-23 at 12:55 +0300, Avi Kivity wrote: > On 09/23/2009 12:20 PM, Mike Galbraith wrote: > > > > Yup, brown baggie variety. Oh darn. > > > > perf_counter tools: fix brown baggie module symbol loading bug. > > > > If there are no modules currently loaded, or the last module scanned is not > > loaded, dso__load_modules() steps on the value from dso__load_vmlinux(), so > > we happily load the kallsyms symbols on top of what we've already loaded. > > > > Fix that such that the total count of symbols loaded is returned. Should > > module symbol load fail after parsing of vmlinux, is's a hard failure, so > > do not silently fall-back to kallsyms. > > > > > > Still fails, but differently. Now 'annotate -k ... -m -v -v' doesn't > list vmx_vcpu_run at all, even though it's prominent in 'perf top'. > > In addition to applying your patch I've merged current linus, so that > may have introduced the problem. > > If I don't supply -k -m, I get > > $ perf annotate -v -v vmx_vcpu_run | grep vmx_vcpu > new symbol: ffffffffa006f596 [0000dead]: vmx_vcpu_run [kvm_intel], > hist: (nil), obj_start: (nil) > new symbol: ffffffffa007025f [0000dead]: vmx_vcpu_put [kvm_intel], > hist: (nil), obj_start: (nil) > new symbol: ffffffffa0070bf6 [0000dead]: vmx_vcpu_load [kvm_intel], > hist: (nil), obj_start: (nil) > new symbol: ffffffffa0070d99 [0000dead]: vmx_vcpu_reset [kvm_intel], > hist: (nil), obj_start: (nil) > ffffffffa006f596-ffffffffa006fb73 vmx_vcpu_run [kvm_intel] > ffffffffa007025f-ffffffffa007026e vmx_vcpu_put [kvm_intel] > ffffffffa0070bf6-ffffffffa0070d98 vmx_vcpu_load [kvm_intel] > ffffffffa0070d99-ffffffffa0071191 vmx_vcpu_reset [kvm_intel] > Error: symbol 'vmx_vcpu_run' not present amongst the samples.
Yeah, I saw oddities with your config. I'm rebuilding your config now with more modules to do more testing.
-Mike
| ![\](/images/icornerr.gif) |