Messages in this thread | | | Subject | Re: checkpatch as a tool (was Re: [RFC][PATCH] SCHED_EDF scheduling class) | From | Daniel Walker <> | Date | Tue, 22 Sep 2009 18:11:39 -0700 |
| |
On Tue, 2009-09-22 at 18:01 -0700, Joe Perches wrote: > On Tue, 2009-09-22 at 17:51 -0700, Daniel Walker wrote: > > I'll stop sending those > > emails if it's actually negative , but I don't think it is.. > > Hi Daniel. > > I think it'd be more helpful if instead of merely sending > a "hah! checkpatch failure!" email you send the submitter > a gentler nudge and a fixed patch.
I don't say "hah!" like I caught you or something .. I could try to soften the emails further so that's not the feeling .. As far as sending fixed patches to people it's not really feasible due to the number of patches I would have to send out.. The other issues is that if I send a corrected patch I could become responsible for that persons patch instead of them .. I could send out delta patches, however, I don't want people to rely on me to fix these issues.. Ideally people would correct them prior to sending the patches out..
Daniel
| |