lkml.org 
[lkml]   [2009]   [Sep]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: best practices: which "uaccess.h" should one include?
Date
On Tuesday 22 September 2009, Robert P. J. Day wrote:
> philosophically, which is the "correct" uaccess.h header file to
> include in kernel code -- <linux/uaccess.h> or <asm/uaccess.h>? the
> first explicitly includes the second so that's a safe choice but,
> generally, there's been a tendency to shift toward including the
> "linux" header files. opinion? there's quite a mixture under the
> drivers/ directory.

The preferred one is linux/uaccess.h, the same is true for many
headers that traditionally only existed in asm/.

There are some headers with explicit #warning or #error messages
when they are not included from linux/foo.h, e.g. spinlock_types.h,
bitops.h or rwsem.h.

Other headers include each other both ways, e.g. futex.h, which means
that you can use either one, though it might be good to move to
a common location if that doesn't cause too much churn.

Arnd <><


\
 
 \ /
  Last update: 2009-09-22 14:11    [W:1.206 / U:0.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site