Messages in this thread | | | Date | Mon, 21 Sep 2009 14:44:23 -0700 | From | Andrew Morton <> | Subject | Re: [lm-sensors] [PATCH] hwmon: Driver for Texas Instruments amc6821 chip |
| |
On Wed, 9 Sep 2009 09:34:35 +0200 Jean Delvare <khali@linux-fr.org> wrote:
> > #define set_temp_para(name, reg)\ > > static ssize_t set_##name(\ > > struct device *dev,\ > > struct device_attribute *attr,\ > > const char *buf,\ > > size_t count)\ > > {\ > > return set_helper(dev, attr, buf, count, &dev->name);\ > > } > > > > And then do all the real work in a common function? Rather than > > expanding tens of copies of the same thing? > > Yes please. We got rid of macro-generated callbacks in most hwmon > drivers a couple years ago already.
I never received an update to this patch so I'm retaining it in my tree for now.
| |