Messages in this thread | | | Subject | Re: [PATCH 2/4] send callback when swap slot is freed | From | Pekka Enberg <> | Date | Mon, 21 Sep 2009 14:12:30 +0300 |
| |
Hi Hugh,
On Mon, 2009-09-21 at 12:07 +0100, Hugh Dickins wrote: > Is the main basis for your disgust at the way that Nitin installs the > callback, that loop down the swap_info_structs? I should point out > that it was I who imposed that on Nitin: before that he was passing a > swap entry (or was it a swap type extracted from a swap entry? > I forget), which was the sole reference to a swp_entry_t in his > driver - I advised a bdev interface.
The callback setup from ->read() just looks gross. However, it's your call Hugh so I'll just shut up now. ;-)
Pekka
| |