Messages in this thread | | | Date | Sun, 20 Sep 2009 20:06:32 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH] x86: Don't ack_APIC_irq() if lapic is disabled in GENERIC_INTERRUPT_VECTOR handler |
| |
* Sheng Yang <sheng@linux.intel.com> wrote:
> Otherwise would cause trouble... > > Cc: Dimitri Sivanich <sivanich@sgi.com> > Signed-off-by: Sheng Yang <sheng@linux.intel.com> > --- > arch/x86/kernel/irq.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/arch/x86/kernel/irq.c b/arch/x86/kernel/irq.c > index b0cdde6..78b23d0 100644 > --- a/arch/x86/kernel/irq.c > +++ b/arch/x86/kernel/irq.c > @@ -257,7 +257,8 @@ void smp_generic_interrupt(struct pt_regs *regs) > { > struct pt_regs *old_regs = set_irq_regs(regs); > > - ack_APIC_irq(); > + if (!disable_apic) > + ack_APIC_irq();
Wont in that case the apic->ack method be a NOP?
Ingo
| |