lkml.org 
[lkml]   [2009]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] input/keyboard: new driver for ADP5520 MFD PMICs
On Thu, 17 Sep 2009 14:24:10 -0400 Mike Frysinger <vapier@gentoo.org> wrote:

> ...
> +struct adp5520_keys {
> + struct input_dev *input;
> + struct notifier_block notifier;
> + struct device *master;
> + unsigned short keycode[ADP5520_KEYMAPSIZE];

Where is ADP5520_KEYMAPSIZE defined?

I can find a single instance in the tree:

./arch/blackfin/mach-bf537/boards/stamp.c:static const unsigned short adp5520_keymap[ADP5520_KEYMAPSIZE] = {

is it runtime-generated or something?

> +};
> +
> +static void adp5520_keys_report_event(struct adp5520_keys *dev,
> + unsigned short keymask, int value)
> +{
> + int i;
> +
> + for (i = 0; i < ADP5520_MAXKEYS; i++)

Where is ADP5520_MAXKEYS defined?

> + if (keymask & (1 << i))
> + input_report_key(dev->input, dev->keycode[i], value);

It seems odd that keycode is dimensioned with ADP5520_KEYMAPSIZE but
here we iterate up to ADP5520_MAXKEYS.

> +
> + input_sync(dev->input);
> +}
> +
> ...


\
 
 \ /
  Last update: 2009-09-20 08:35    [W:0.248 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site