lkml.org 
[lkml]   [2009]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 7/8] perf: Add a perf record --timechart option

* Arjan van de Ven <arjan@infradead.org> wrote:

> On Mon, 14 Sep 2009 10:06:00 +0200
> Peter Zijlstra <peterz@infradead.org> wrote:
>
> > On Sat, 2009-09-12 at 13:06 +0200, Arjan van de Ven wrote:
> > > This patch adds a "perf record --timechart" option, to make it easy
> > > to capture traces for use by the timechart tool.
> >
> > Would it perhaps make sense to make that:
> >
> > perf timechart record
>
> well yes, but it would just be an alias for the former, since it's the
> record code that has to do the recording... and that's a rather
> obscene layering violation in how perf is set up I think.

No, please do it like 'perf sched record' does - it constructs an
argument list of pre-cooked options. See builtin-sched.c's record_args[]
array.

Ingo


\
 
 \ /
  Last update: 2009-09-19 11:47    [W:0.060 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site