Messages in this thread | | | Date | Sat, 19 Sep 2009 12:20:53 -0400 (EDT) | From | Alan Stern <> | Subject | Re: [PATCH] USB: ftdi_sio: Fix read regression in 2.6.31. |
| |
On Sat, 19 Sep 2009, Johan Hovold wrote:
> Use ASYNCB_INITIALIZED to determine when to stop reading. > > Since 335f8514f200e63d689113d29cb7253a5c282967 port count can no longer > be used to determine when to stop reading from the device as it can be > zero when the first read callbacks are made (see tty_port_block_til_read > where port count is temporarily decremented during serial_open). > > This fixes the regression where reads fail after connecting the device > and opening the port more than once (reads usually succeed after the > first open due to the device latency timer then being set to the default > 16ms rather than 1ms).
This is a good change. It should be made in all the serial drivers, not just ftdi_sio. How'd you like to submit patches for all the rest of the drivers?
Alan Stern
| |