Messages in this thread | | | Date | Mon, 14 Sep 2009 12:00:39 -0600 | From | Jason Gunthorpe <> | Subject | Re: [PATCH] TPM: Fixup pcrs sysfs file |
| |
On Mon, Sep 14, 2009 at 02:45:28PM -0300, Rajiv Andrade wrote:
> Sorry for the delay, just reviewed the patches and Jason is right, > Jason's and Andrew's final work (last patch) is great.
Thnx
> > FWIW, I didn't mention in the patch emails, but all the patches I sent > > fix regressions that have been introduced in the past couple years by > > clean up patches that never tested the code paths they alter.
> Hold on, I tested these functions before when submitting them and they > worked fine, and, I couldn't figure it out why yet (only guesses), they > still work for me here, probably due the mishandling of the be32 > formatted value when calling transmit_cmd().
Ahh, yes, you are right, the pcr thing wouldn't blow up on a LE system, I'm testing on BE. Didn't notice that subtlety. Sorry
Also please look at the last patch Andrew has queued up: http://patchwork.kernel.org/patch/45512/
Regards, Jason
| |