Messages in this thread | | | Date | Tue, 1 Sep 2009 15:58:50 +0800 | From | Wu Fengguang <> | Subject | Re: [PATCH] pagemap: document KPF_KSM and show it in page-types |
| |
On Tue, Sep 01, 2009 at 12:41:51AM +0800, Chris Wright wrote: > * Wu Fengguang (fengguang.wu@intel.com) wrote: > > It indicates to the system admin that processes mapping such pages may be > > eating less physical memory than the reported numbers by legacy tools. > > > > CC: Hugh Dickins <hugh.dickins@tiscali.co.uk> > > CC: Chris Wright <chrisw@redhat.com> > > CC: Izik Eidus <ieidus@redhat.com> > > Signed-off-by: Wu Fengguang <fengguang.wu@intel.com> > > Acked-by: Chris Wright <chrisw@redhat.com>
Thanks.
> > --- linux-mm.orig/tools/vm/page-types.c 2009-08-31 15:00:24.000000000 +0800 > > +++ linux-mm/tools/vm/page-types.c 2009-08-31 15:02:10.000000000 +0800 > > @@ -49,6 +49,7 @@ > > #define KPF_UNEVICTABLE 18 > > #define KPF_HWPOISON 19 > > #define KPF_NOPAGE 20 > > +#define KPF_KSM 21 > > Doesn't this highlight the trouble w/ maintaining two copies of same info?
Yes, I even had patch to move these numbers to page-flags.h. however given that we have to update the flag name strings anyway, this is not a big extra burden?
Thanks, Fengguang
| |