Messages in this thread | | | Date | Tue, 1 Sep 2009 12:43:06 +0400 | Subject | Re: [Question] x86,APIC: In apicdef.h dfr,svr,...... shouldn't be const? | From | Cyrill Gorcunov <> |
| |
On 9/1/09, Rakib Mullick <rakib.mullick@gmail.com> wrote: > Hello guys, Intel System programmers guide says - dfr, svr, esr - this > registers should be readonly. So shouldn't they use const? Or is it > anything else?
Hi Rakib, i dont have sources under my hands at moment, but iirc there were situations we nees to poke esr register.
> > And apicdef.h also contains a style problem, checkpatch warns about > following style: > > u32 spurious_vector : 8 > > Check patch wants as: > > u32 spurious_vector:8 > > Shouldn't this issues be fixed? > > Thanks, > --
i dont see reason why not ;) though i wonder why we need this structure at all. We may have extended amd entries. Yinghai cced.
| |