lkml.org 
[lkml]   [2009]   [Sep]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [Question] x86,APIC: In apicdef.h dfr,svr,...... shouldn't be const?
From
On 9/1/09, Rakib Mullick <rakib.mullick@gmail.com> wrote:
> Hello guys, Intel System programmers guide says - dfr, svr, esr - this
> registers should be readonly. So shouldn't they use const? Or is it
> anything else?

Hi Rakib, i dont have sources under my hands at moment, but iirc there
were situations we nees to poke esr register.

>
> And apicdef.h also contains a style problem, checkpatch warns about
> following style:
>
> u32 spurious_vector : 8
>
> Check patch wants as:
>
> u32 spurious_vector:8
>
> Shouldn't this issues be fixed?
>
> Thanks,
> --

i dont see reason why not ;)
though i wonder why we need this structure at all. We may have
extended amd entries.
Yinghai cced.


\
 
 \ /
  Last update: 2009-09-01 10:45    [W:0.080 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site