Messages in this thread | | | From | "Luck, Tony" <> | Date | Tue, 1 Sep 2009 16:20:34 -0700 | Subject | RE: [RFC][PATCH] ia64: fix csum_ipv6_magic() |
| |
>--- a/arch/ia64/lib/ip_fast_csum.S >+++ b/arch/ia64/lib/ip_fast_csum.S >@@ -96,20 +96,22 @@ END(ip_fast_csum) > GLOBAL_ENTRY(csum_ipv6_magic) > ld4 r20=[in0],4 > ld4 r21=[in1],4 >- dep r15=in3,in2,32,16 >+ zxt4 in3=in3
I think this zxt4 instruction have a typo. You really want to zap the high part on "in2" here (the "len") parameter. "in3" contains the "proto" argument, which is only 16-bits. But any garbage in the high part on in3 will be dropped by the "dep" instruction later which only pulls out the low 16 bits from it.
So I think you meant to type:
zxt4 in2=in2
Does this make sense?
-Tony
| |