Messages in this thread | | | Date | Wed, 2 Sep 2009 00:37:01 +0200 | From | Frederic Weisbecker <> | Subject | Re: [PATCH 1/3] tracing: make splice_read work when data is sufficient |
| |
On Tue, Sep 01, 2009 at 08:29:53PM +0800, Lai Jiangshan wrote: > Frederic Weisbecker wrote: > >> */ > >> + cpu_buffer->reader_page->read = 0; > > > > > > > > Wasn't this reset done before? > > > > > > This is not reset. It is still used just before this line.
Yeah but after that it's not used anymore because this page won't anymore be used as a reader page but will be integrated as a writable ring buffer page.
One day it may be reused as a reader page still, but before any use, rb_reset_reader_page() will be called to reset this offset.
So I just don't understand why you need to do that.
> > > > > > Reviewed-by: Frederic Weisbecker <fweisbec@gmail.com> > > > > > > Ingo, Could you apply this patch and fix the bug? >
| |