Messages in this thread | | | Date | Tue, 1 Sep 2009 15:06:28 +0200 | From | Borislav Petkov <> | Subject | Re: [tip:x86/cpu] x86, msr: Add rd/wrmsr interfaces with preset registers |
| |
On Tue, Sep 01, 2009 at 01:05:13PM +0200, Ingo Molnar wrote: > > * tip-bot for Borislav Petkov <petkovbb@googlemail.com> wrote: > > > Commit-ID: 132ec92f3f70fe365c1f4b8d46e66cf8a2a16880 > > Gitweb: http://git.kernel.org/tip/132ec92f3f70fe365c1f4b8d46e66cf8a2a16880 > > Author: Borislav Petkov <petkovbb@googlemail.com> > > AuthorDate: Mon, 31 Aug 2009 09:50:09 +0200 > > Committer: H. Peter Anvin <hpa@zytor.com> > > CommitDate: Mon, 31 Aug 2009 15:14:26 -0700 > > > > x86, msr: Add rd/wrmsr interfaces with preset registers > > FYI, -tip testing found a build failure on x86 with these patches: > > arch/x86/lib/msr-reg.S:14: Error: Bad macro parameter list > arch/x86/lib/msr-reg.S:100: Error: invalid character '_' in mnemonic > arch/x86/lib/msr-reg.S:101: Error: invalid character '_' in mnemonic > > config attached. I've excluded this topic branch from tip:master for > now.
I can't trigger it here.
Stab in the dark: It could be an old binutils issue since gas can't swallow the macro definition. If you're building on a RHEL system, it could be that the ":req" macro argument specification is not supported by that particular version of the gnu assembler as http://www.redhat.com/docs/manuals/enterprise/RHEL-4-Manual/gnu-assembler/macro.html doesn't state anything on required macro arguments.
Try removing the ":req" part if the op macro argument to see whether it builds. If so, ":req" is not absolutely necessary and we can do away without it.
-- Regards/Gruss, Boris.
Operating | Advanced Micro Devices GmbH System | Karl-Hammerschmidt-Str. 34, 85609 Dornach b. München, Germany Research | Geschäftsführer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni Center | Sitz: Dornach, Gemeinde Aschheim, Landkreis München (OSRC) | Registergericht München, HRB Nr. 43632
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |