Messages in this thread | ![/](/images/icornerl.gif) | | Date | Fri, 7 Aug 2009 18:17:51 +0100 | Subject | Re: [PATCH 2/7 v3] initdev:kernel:USB init device discovery notification | From | Alan Jenkins <> |
| |
On 8/7/09, Alan Stern <stern@rowland.harvard.edu> wrote: > On Fri, 7 Aug 2009, Alan Jenkins wrote: > >> > +/* The mask of possible USB boot devices depends on what drivers and >> > + * options have been configured into the kernel. There are too many >> > + * USB network config options to list here, so just assume it is always >> > + * possible to have a USB network device. >> > + */ >> >> That could be fixed though. Make the "USB Network Adaptors" menu into >> an option. Then you just have e.g. "CONFIG_NETDEV_USB", plus the two >> class devices outside the menu (CONFIG_USB_ACM and CONFIG_USB_WDM).
Oops, scratch WDM. It doesn't actually provide a network device (otherwise it would depend on NET).
> That could be done. It might even meet with the approval of the > networking maintainer, independent of this patch series. > > But what if somebody adds yet another networking class driver outside > the menu?
Hmm.
Ok, how about a single (hidden) USB_HAS_NETDEV. NETDEV_USB and USB_ACM select USB_HAS_NETDEV.
Textual juxtaposition or simple copy+paste inside class/Kconfig should help it get picked up. And I'd add a comment pointing the bewildered to the definition of usb_initdev_mask.
I'll write a patch for your inspection this evening.
Alan
| ![\](/images/icornerr.gif) |