Messages in this thread Patch in this message | | | Date | Fri, 07 Aug 2009 18:53:21 +0800 | From | Zhaolei <> | Subject | [PATCH v2 1/2] ftrace: Rename set_tracer_flags()'s local variable trace_flags |
| |
set_tracer_flags() have a local variable named trace_flags which have same name with global one. Actually, using tracer_flags should be better by its meaning.
Changelog: v1->v2: Simplied another patch in this patchset, no change in this patch.
[ Impact: cleanup ]
Signed-off-by: Zhao Lei <zhaolei@cn.fujitsu.com> --- kernel/trace/trace.c | 14 +++++++------- 1 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index 6344573..6c5f67f 100644 --- a/kernel/trace/trace.c +++ b/kernel/trace/trace.c @@ -2117,23 +2117,23 @@ tracing_trace_options_read(struct file *filp, char __user *ubuf, /* Try to assign a tracer specific option */ static int set_tracer_option(struct tracer *trace, char *cmp, int neg) { - struct tracer_flags *trace_flags = trace->flags; + struct tracer_flags *tracer_flags = trace->flags; struct tracer_opt *opts = NULL; int ret = 0, i = 0; int len; - for (i = 0; trace_flags->opts[i].name; i++) { - opts = &trace_flags->opts[i]; + for (i = 0; tracer_flags->opts[i].name; i++) { + opts = &tracer_flags->opts[i]; len = strlen(opts->name); if (strncmp(cmp, opts->name, len) == 0) { - ret = trace->set_flag(trace_flags->val, + ret = trace->set_flag(tracer_flags->val, opts->bit, !neg); break; } } /* Not found */ - if (!trace_flags->opts[i].name) + if (!tracer_flags->opts[i].name) return -EINVAL; /* Refused to handle */ @@ -2141,9 +2141,9 @@ static int set_tracer_option(struct tracer *trace, char *cmp, int neg) return ret; if (neg) - trace_flags->val &= ~opts->bit; + tracer_flags->val &= ~opts->bit; else - trace_flags->val |= opts->bit; + tracer_flags->val |= opts->bit; return 0; } -- 1.5.5.3
| |