Messages in this thread | | | Date | Thu, 6 Aug 2009 17:07:41 +0900 | Subject | Re: [PATCH for 2.6.31 0/4] fix oom_adj regression v2 | From | Minchan Kim <> |
| |
Hi, Kosaki.
On Thu, Aug 6, 2009 at 2:13 PM, KOSAKI Motohiro<kosaki.motohiro@jp.fujitsu.com> wrote: >> So I merged these but I have a feeling that this isn't the last I'll be >> hearing on the topic ;) >> >> Given the amount of churn, the amount of discussion and the size of the >> patches, this doesn't look like something we should push into 2.6.31. >> >> If we think that the 2ff05b2b regression is sufficiently serious to be >> a must-fix for 2.6.31 then can we please find something safer and >> smaller? Like reverting 2ff05b2b? > > I don't think the serious problem is only this issue, I oppose to > ignore regression > bug report ;-) > > Yes, your point makes sense. then, I'll make two patch series. > 1. reverting 2ff05b2b for 2.6.31 > 2. retry fix oom livelock for -mm > > I expect I can do that next sunday. > > >> These patches clash with the controversial >> mm-introduce-proc-pid-oom_adj_child.patch, so I've disabled that patch >> now. > > I think we can drop this because workaround patch is only needed until > the issue not fixed.
I looked over your this patches. I can't find out merge point our both idea.
I think it would be better than mine.
As kame pointed out, you patch can solve long stall time of do_each_thread as well as livelock.
So I will wait for you to finish this work and review then. I ask you add me in CC, then. :)
Thanks.
> > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: <a hrefmailto:"dont@kvack.org"> email@kvack.org </a> >
-- Kind regards, Minchan Kim -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |