Messages in this thread | | | Date | Fri, 07 Aug 2009 08:26:58 +0900 | From | Tejun Heo <> | Subject | Re: [PATCH 2.6.32 v2] MCP55 SATA2 conditional MSI support for sata_nv |
| |
Robert Hancock wrote: >> If I'm not wrong then that's how it's supposed to be done. free_irq >> and then disable_msi. You can't reverse the order. Also the driver >> should know when to quiesce the ASIC. So quiesce first and then >> shutdown everything. > > Seems like devres should handle this somehow, or else something in > libata core.. Tejun?
Yeah, if the device was enabled with pcim_enable_device(), devres will take of all the cleanups. No need to worry about them.
Thanks.
-- tejun
| |