lkml.org 
[lkml]   [2009]   [Aug]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Linux-2.6.31-rc4 - shut the annoying "failed to acquire vblank..."
On Thu, 30 Jul 2009 13:06:50 +0200
Frans Pop <elendil@planet.nl> wrote:

> Paul Rolland wrote:
> > Some applications/hardware combinations are triggering the message
> > "failed to acquire vblank counter" to be issued up to 20 times a
> > second, which makes it both useless and dangerous, as this may hide
> > other important messages. This changes makes it only appear when
> > people are debugging.
> >
> > Signed-off-by: Paul Rolland <rol@as2917.net>
> > Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> >
> > --- linux-2.6.31-rc4/drivers/gpu/drm/drm_irq.c.orig 2009-07-26
> > 21:36:20.000000000 +0200 +++
> > linux-2.6.31-rc4/drivers/gpu/drm/drm_irq.c 2009-07-26
> > 21:36:34.000000000 +0200 @@ -566,7 +566,7 @@ int
> > drm_wait_vblank(struct drm_device *d
> >
> > ret = drm_vblank_get(dev, crtc);
> > if (ret) {
> > - DRM_ERROR("failed to acquire vblank counter,
> > %d\n", ret);
> > + DRM_DEBUG("failed to acquire vblank counter,
> > %d\n", ret); return ret;
> > }
> > seq = drm_vblank_count(dev, crtc);
>
> Actually, I just see that I get a different, but related error on
> suspend and when opening/closing a second X session:
> *ERROR* trying to get vblank count for disabled pipe 0/1
>
> Would it make sense to add the following to this patch:

Yes, that would be a good second patch (I also sent this one a few
times but it keeps getting lost). If you want to send it to Linus more
formally, you can add my reviewed-by.

Thanks,
--
Jesse Barnes, Intel Open Source Technology Center


\
 
 \ /
  Last update: 2009-08-06 23:33    [W:0.057 / U:0.364 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site