Messages in this thread | | | Date | Thu, 6 Aug 2009 14:15:46 -0400 | From | Dave Jones <> | Subject | Re: [PATCH] pci_ids.h: add new Atheros USB vendor ID |
| |
On Wed, Aug 05, 2009 at 10:09:32PM -0700, Greg Kroah-Hartman wrote: > > the closest we have is drivers/hid/hid-ids.h and we might just should > > have Greg create a usb-ids.h file. > > Ick, no, there's no such file for a good reason. Put your device ids in > the driver files, no need to share it across the whole kernel.
I agree. In fact, I'd go further, and say that the bulk of what we have in pci_ids.h is also pointlessly shared. Only a tiny fraction of the device entries in that file are used by multiple files in the kernel.
Dave
| |