Messages in this thread Patch in this message | | | Date | Wed, 5 Aug 2009 18:59:45 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH 3/3] checkincludes.pl: add option to remove duplicates in place |
| |
On Wed, 5 Aug 2009 17:51:12 -0700 "Luis R. Rodriguez" <lrodriguez@Atheros.com> wrote:
> checkincludes.pl is more useful if it actually removed > the lines. This adds support for that with -r. >
hm, spose so. It can't do any harm.
Plus it's about time we edited that file - it hasn't been changed since we started the bk tree.
> --- > scripts/checkincludes.pl | 57 +++++++++++++++++++++++++++++++++++++++++----- > 1 files changed, 51 insertions(+), 6 deletions(-) > > diff --git a/scripts/checkincludes.pl b/scripts/checkincludes.pl > index 4bff139..5a53407 100755 > --- a/scripts/checkincludes.pl > +++ b/scripts/checkincludes.pl > @@ -2,32 +2,77 @@ > # > # checkincludes: Find files included more than once in (other) files. > # Copyright abandoned, 2000, Niels Kristian Bech Jensen <nkbj@image.dk>. > +# Copyright abandoned, 2009, Luis R. Rodriguez <mcgrof@gmail.com> > > sub usage { > - print "Usage: checkincludes.pl <file list>\n"; > + print "Usage: checkincludes.pl [-r]\n"; > + print "By default we just warn of duplicates\n"; > + print "To remove files in place use -r\n";
I'm not sure I like the wording here - I don't _want_ my files removed!
This?
--- a/scripts/checkincludes.pl~checkincludespl-add-option-to-remove-duplicates-in-place-fix +++ a/scripts/checkincludes.pl @@ -7,7 +7,7 @@ sub usage { print "Usage: checkincludes.pl [-r]\n"; print "By default we just warn of duplicates\n"; - print "To remove files in place use -r\n"; + print "To remove duplicated includes in place use -r\n"; exit 1; } _
| |