lkml.org 
[lkml]   [2009]   [Aug]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC] respect the referenced bit of KVM guest pages?
Andrea Arcangeli wrote:
> On Wed, Aug 05, 2009 at 10:40:58AM +0800, Wu Fengguang wrote:
>> */
>> - if ((vm_flags & VM_EXEC) && !PageAnon(page)) {
>> + if ((vm_flags & VM_EXEC) || PageAnon(page)) {
>> list_add(&page->lru, &l_active);
>> continue;
>> }
>>
>
> Please nuke the whole check and do an unconditional list_add;
> continue; there.

<riel> aa: so you're saying we should _never_ add pages to the active
list at this point in the code
<aa> right
<riel> aa: and remove the list_add and continue completely
<aa> yes
<riel> aa: your email says the opposite :)

--
All rights reversed.


\
 
 \ /
  Last update: 2009-08-05 19:47    [W:2.922 / U:0.388 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site