Messages in this thread | | | Date | Wed, 5 Aug 2009 18:58:37 +0200 | From | Daniel Mack <> | Subject | Re: [PATCH 1/2] ds2760: switch to new dev_pm_ops |
| |
On Wed, Aug 05, 2009 at 04:57:47PM +0200, Frans Pop wrote: > Daniel Mack wrote: > > +static struct dev_pm_ops ds2760_battery_pm_ops = { > > + .suspend = ds2760_battery_suspend, > > + .resume = ds2760_battery_resume, > > +}; > > Just to make sure... > > Have you followed the earlier discussions on dev_pm_ops conversions and > are you aware that if done like this the driver no longer supports > hibernation? > > If omitting hibernation is intentional, it should probably be justified in > the commit log. > > See http://lkml.org/lkml/2009/7/25/118 for background.
Hmm, I tested that on a embedded hardware platform which doesn't supoprt hibernation anyway. But you're right, to prevent regressions, .freeze and .thaw should probably be given as well.
I'll fix that and resend.
Thanks, Daniel
| |