Messages in this thread | | | Subject | Re: [PATCH 1/1] XFS: xfs_iformat realtime device target pointer check | From | Ramon de Carvalho Valle <> | Date | Wed, 05 Aug 2009 13:34:02 -0300 |
| |
On Wed, 2009-08-05 at 11:17 -0400, Christoph Hellwig wrote: > On Tue, Aug 04, 2009 at 03:51:38PM -0300, Ramon de Carvalho Valle wrote: > > The xfs_iformat function does not check if the realtime device target pointer > > is valid when the XFS_DIFLAG_REALTIME flag is set on the ondisk inode > > structure. > > Same as Eric I don't think there's much of a point renumbering the error > cases. Instead I'll do another patch with a couple of cleanups in this > function replacing all the numbers with short alphabetic tags.
Great. Thanks.
> > I don't really see the point of printing the flags either, if we have > this bit flipped it's pretty clear that we had random corruption of this > dinode. >
Printing the flags is just for debugging purposes and it keeps the code consistent with the other calls to xfs_fs_repair_cmn_err.
-Ramon [unhandled content-type:application/pgp-signature] | |