Messages in this thread | | | Subject | Re: [PATCH] perf report: Make --sort comm,dso,symbol the default | From | Peter Zijlstra <> | Date | Wed, 05 Aug 2009 12:41:18 +0200 |
| |
On Wed, 2009-08-05 at 13:25 +0300, Pekka Enberg wrote: > If you're doing performance testing, you're interested in the symbols > anyway so lets make "--sort comm,dso,symbol" the default sort option.
Seems sensible,
Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi> > --- > tools/perf/builtin-report.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c > index b20a4b6..181cef1 100644 > --- a/tools/perf/builtin-report.c > +++ b/tools/perf/builtin-report.c > @@ -31,7 +31,7 @@ > static char const *input_name = "perf.data"; > static char *vmlinux = NULL; > > -static char default_sort_order[] = "comm,dso"; > +static char default_sort_order[] = "comm,dso,symbol"; > static char *sort_order = default_sort_order; > static char *dso_list_str, *comm_list_str, *sym_list_str, > *col_width_list_str; > @@ -1423,7 +1423,7 @@ print_entries: > if (sort_order == default_sort_order && > parent_pattern == default_parent_pattern) { > fprintf(fp, "#\n"); > - fprintf(fp, "# (For more details, try: perf report --sort comm,dso,symbol)\n"); > + fprintf(fp, "# (For an high level overview, try: perf report --sort comm,dso)\n"); > fprintf(fp, "#\n"); > } > fprintf(fp, "\n");
| |