Messages in this thread | ![/](/images/icornerl.gif) | | Date | Sun, 30 Aug 2009 21:39:00 +0800 | From | Américo Wang <> | Subject | Re: [PATCH] x86: detect stack protector for i386 builds on x86_64 |
| |
On Sat, Aug 29, 2009 at 06:27:18PM +0200, Michal Schmidt wrote: >Stack protector support was not detected when building with ARCH=i386 >on x86_64 systems: >arch/x86/Makefile:80: stack protector enabled but no compiler support > >The "-m32" argument needs to be passed to the detection script. > >Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
Looks fine.
Acked-by: WANG Cong <xiyou.wangcong@gmail.com>
> >-- >diff --git a/arch/x86/Makefile b/arch/x86/Makefile >index 1b68659..5e7db44 100644 >--- a/arch/x86/Makefile >+++ b/arch/x86/Makefile >@@ -72,7 +72,7 @@ endif > > ifdef CONFIG_CC_STACKPROTECTOR > cc_has_sp := $(srctree)/scripts/gcc-x86_$(BITS)-has-stack-protector.sh >- ifeq ($(shell $(CONFIG_SHELL) $(cc_has_sp) $(CC)),y) >+ ifeq ($(shell $(CONFIG_SHELL) $(cc_has_sp) $(CC) $(biarch)),y) > stackp-y := -fstack-protector > stackp-$(CONFIG_CC_STACKPROTECTOR_ALL) += -fstack-protector-all > KBUILD_CFLAGS += $(stackp-y) >-- >To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >the body of a message to majordomo@vger.kernel.org >More majordomo info at http://vger.kernel.org/majordomo-info.html >Please read the FAQ at http://www.tux.org/lkml/
-- Live like a child, think like the god.
| ![\](/images/icornerr.gif) |