Messages in this thread | ![/](/images/icornerl.gif) | | Date | Sat, 29 Aug 2009 22:52:59 -0400 | From | Mark Lord <> | Subject | Re: [PATCH 6/7] block: allow large discard requests |
| |
Matthew Wilcox wrote: > On Sat, Aug 29, 2009 at 10:49:02PM -0400, Mark Lord wrote: >> Pardon my cursory review, but I don't see where this >> patch set allows for more than a single extent/range >> of sectors per TRIM command. > > It doesn't. > >> If it still does not group many extents into a single TRIM, >> then it will be far to slow to be useful at all for SATA. > > That depends on the firmware. I do have plans to group the extents, > but let's get something working before making it quick. ..
In this situation, it's more a case of making it *not sucky slow* than getting to the point where we think about making it "quick".
One extent at a time is glacial.
Cheers
| ![\](/images/icornerr.gif) |