Messages in this thread Patch in this message | | | Date | Wed, 26 Aug 2009 19:13:19 GMT | From | tip-bot for Cyrill Gorcunov <> | Subject | [tip:x86/apic] x86, apic: Slim down stack usage in early_init_lapic_mapping() |
| |
Commit-ID: d3a247bfb2c26f5b67367d58af7ad8c2efbbc6c1 Gitweb: http://git.kernel.org/tip/d3a247bfb2c26f5b67367d58af7ad8c2efbbc6c1 Author: Cyrill Gorcunov <gorcunov@openvz.org> AuthorDate: Wed, 26 Aug 2009 21:13:24 +0400 Committer: Ingo Molnar <mingo@elte.hu> CommitDate: Wed, 26 Aug 2009 20:26:23 +0200
x86, apic: Slim down stack usage in early_init_lapic_mapping()
As far as I see there is no external poking of mp_lapic_addr in this procedure which could lead to unpredited changes and require local storage unit for it. Lets use it plain forward.
Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org> Cc: Yinghai Lu <yinghai@kernel.org> LKML-Reference: <20090826171324.GC4548@lenovo> Signed-off-by: Ingo Molnar <mingo@elte.hu>
--- arch/x86/kernel/apic/apic.c | 8 ++------ 1 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c index 3fc3a6c..159740d 100644 --- a/arch/x86/kernel/apic/apic.c +++ b/arch/x86/kernel/apic/apic.c @@ -1562,8 +1562,6 @@ no_apic: #ifdef CONFIG_X86_64 void __init early_init_lapic_mapping(void) { - unsigned long phys_addr; - /* * If no local APIC can be found then go out * : it means there is no mpatable and MADT @@ -1571,11 +1569,9 @@ void __init early_init_lapic_mapping(void) if (!smp_found_config) return; - phys_addr = mp_lapic_addr; - - set_fixmap_nocache(FIX_APIC_BASE, phys_addr); + set_fixmap_nocache(FIX_APIC_BASE, mp_lapic_addr); apic_printk(APIC_VERBOSE, "mapped APIC to %16lx (%16lx)\n", - APIC_BASE, phys_addr); + APIC_BASE, mp_lapic_addr); /* * Fetch the APIC ID of the BSP in case we have a
| |