Messages in this thread | | | Date | Wed, 26 Aug 2009 08:49:16 +0800 | From | Xiao Guangrong <> | Subject | Re: [PATCH 1/2] trace_events: fix napi's tracepoint |
| |
Neil Horman wrote: > On Tue, Aug 25, 2009 at 09:58:16AM +0200, Ingo Molnar wrote: >> * Xiao Guangrong <xiaoguangrong@cn.fujitsu.com> wrote: >> >> This will collide with tracing bits in the networking tree. The >> skb-tracing plugin there should be turned into proper TRACE_EVENT() >> tracepoints. >> >> Neil was away for some time but i think soon we should see some >> movement here. >> >> Ingo >> > > Thank you Ingo, yes, I'm back from the beach now and will look at this shortly. > I concur, we should just convert the napi_poll tracepoint to be defined via the > TRACE_EVENT macro, same as the kfree_skb tracepoint. Xaio would you like to > take care of that, or shall I? >
Hi Neil,
I'm glad to do it.
Actually, we should fix the include file dependencies first (the second patch in this patchset), else we can't include two TRACE_EVENT head files in net-traces.c
Steve will pull this patchset, so, I'll convert it after this patchset merged.
| |