lkml.org 
[lkml]   [2009]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] hwmon: applesmc: restore keyboard backlight on resume
Andrew Morton wrote:
> On Sat, 22 Aug 2009 23:33:52 +0200
> "Henrik Rydberg" <rydberg@euromail.se> wrote:
>
>> On resume from suspend, the driver currently resets the logical
>> state as if it was brought up from halt. This patch uses the
>> dev_pm_ops.resume method to synchronize the hardware with the
>> memorized logical state, bringing back the backlight to the level
>> prior to suspend.
>
> What are the runtime effects of this change?
>

My apologies, the patch has two flaws.

1) For macbook models without keyboard backlight, the resume function
will fail internally, presumably resulting in a small unnecessary delay.

2) The accelerometer does not reset properly after hibernation.

Please drop this patch from -mm, I am sending a corrected patch
with a slightly different title. Sorry about this.

Henrik


\
 
 \ /
  Last update: 2009-08-25 01:51    [W:6.280 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site