Messages in this thread | | | Date | Mon, 24 Aug 2009 22:09:50 +0200 | From | Johannes Weiner <> | Subject | Re: [PATCH] Add kerneldoc for flush_scheduled_work() |
| |
Hello Randy,
On Mon, Aug 24, 2009 at 12:27:11PM -0700, Randy Dunlap wrote: > On Mon, 24 Aug 2009 12:06:54 -0700 (PDT) Johannes Weiner wrote: > > I'll add this to my kernel-doc quilt patch series.
Thanks!
> Oh, one question below...
> > @@ -2119,11 +2122,19 @@ sub process_file($) { > > } elsif (/$doc_content/) { > > # miguel-style comment kludge, look for blank lines after > > # @parameter line to signify start of description > > - if ($1 eq "" && > > - ($section =~ m/^@/ || $section eq $section_context)) { > > - dump_section($file, $section, xml_escape($contents)); > > - $section = $section_default; > > - $contents = ""; > > + if ($1 eq "") { > > + if ($section =~ m/^@/ || $section eq $section_context) { > > + dump_section($file, $section, xml_escape($contents)); > > + $section = $section_default; > > + $contents = ""; > > + } else { > > + $contents .= "\n"; > > + } > > + $in_purpose = 0; > > + } elsif ($in_purpose == 1) { > > + # Continued declaration purpose > > + chomp($declaration_purpose); > > + $declaration_purpose .= " " . $1; > > Why shouldn't this be: > $declaration_purpose .= " " . xml_escape($1); > ?
Sorry, this should be escaped of course! Could you edit the patch on your side?
Thanks, Hannes
| |