lkml.org 
[lkml]   [2009]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH -tip 1/2] Add "notrace" to RCU function headers used by ftrace.
    Date
    Both rcu_read_lock_sched_notrace() and rcu_read_unlock_sched_notrace()
    are used by ftrace, and thus need to be marked "notrace". Unfortunately,
    my naive assumption that gcc would see the inner "notrace" does not hold.
    Kudos to Lai Jiangshan for noting this.

    Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
    ---
    include/linux/rcupdate.h | 4 ++--
    1 files changed, 2 insertions(+), 2 deletions(-)

    diff --git a/include/linux/rcupdate.h b/include/linux/rcupdate.h
    index ec90fc3..8b4422c 100644
    --- a/include/linux/rcupdate.h
    +++ b/include/linux/rcupdate.h
    @@ -191,7 +191,7 @@ static inline void rcu_read_lock_sched(void)
    __acquire(RCU_SCHED);
    rcu_read_acquire();
    }
    -static inline void rcu_read_lock_sched_notrace(void)
    +static inline notrace void rcu_read_lock_sched_notrace(void)
    {
    preempt_disable_notrace();
    __acquire(RCU_SCHED);
    @@ -209,7 +209,7 @@ static inline void rcu_read_unlock_sched(void)
    __release(RCU_SCHED);
    preempt_enable();
    }
    -static inline void rcu_read_unlock_sched_notrace(void)
    +static inline notrace void rcu_read_unlock_sched_notrace(void)
    {
    rcu_read_release();
    __release(RCU_SCHED);
    --
    1.5.2.5


    \
     
     \ /
      Last update: 2009-08-24 18:45    [W:4.076 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site