lkml.org 
[lkml]   [2009]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -tip] v3 Renamings to increase RCU clarity.
On Mon, Aug 24, 2009 at 03:17:57PM +0800, Lai Jiangshan wrote:
> Paul E. McKenney wrote:
> > From: Paul E. McKenney <paulmck@linux.vnet.ibm.com>

[ . . . ]

> > +static inline void rcu_read_lock_sched_notrace(void)
> > +{
> > + preempt_disable_notrace();
> > +}
>
> It need be marked "notrace". Sometimes a function marked "inline"
> may not be inlined when it is compiled.
>
> Lai.

Good eyes, and thank you -very- much!!! I doubt that I would have ever
spotted this on my own, as I was just assuming that the compiler would
see the preempt_disable_notrace() directly in all cases...

Thanx, Paul


\
 
 \ /
  Last update: 2009-08-24 17:39    [W:3.540 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site