Messages in this thread | | | Date | Sun, 23 Aug 2009 22:15:26 +0200 | From | Bastian Blank <> | Subject | Re: [GIT PULL] s390 patches for v2.6.31-rc7 |
| |
On Sun, Aug 23, 2009 at 09:37:14PM +0200, Martin Schwidefsky wrote: > +static void __init set_preferred_console(void) > +{ > + if (MACHINE_IS_KVM) { > + add_preferred_console("hvc", 0, NULL); > + s390_virtio_console_init(); > + return; > + }
Why this early return instead of else if as all options are mutually exclusive? Also why do you init the virtio console here instead of an console_initcall?
Bastian
-- Four thousand throats may be cut in one night by a running man. -- Klingon Soldier, "Day of the Dove", stardate unknown
| |