Messages in this thread | ![/](/images/icornerl.gif) | | Date | Sun, 23 Aug 2009 10:53:31 +0200 | From | Ingo Molnar <> | Subject | Re: [tip:timers/core] timekeeping: Increase granularity of read_persistent_clock() |
| |
* Martin Schwidefsky <schwidefsky@de.ibm.com> wrote:
> On Sat, 22 Aug 2009 17:33:46 +0200 > Ingo Molnar <mingo@elte.hu> wrote: > > > > > * Martin Schwidefsky <schwidefsky@de.ibm.com> wrote: > > > > > > FYI, -tip arch-testing found that this commit broke the PowerPC > > > > build: > > > > > > > > /home/mingo/tip/arch/powerpc/kernel/time.c: In function 'read_persistent_clock': > > > > /home/mingo/tip/arch/powerpc/kernel/time.c:788: error: 'return' with a value, in function returning void > > > > /home/mingo/tip/arch/powerpc/kernel/time.c:791: error: 'return' with a value, in function returning void > > > > make[2]: *** [arch/powerpc/kernel/time.o] Error 1 > > > > make[2]: *** Waiting for unfinished jobs.... > > > > make[1]: *** [arch/powerpc/kernel] Error 2 > > > > > > I overlooked a case in the powerpc version of read_persistent_lock. > > > New patch: > > > > the patches are already committed and this patch doesnt apply - mind > > sending a delta fix against tip:master: > > > > http://people.redhat.com/mingo/tip.git/README > > Here we go:
applied, thanks! (i fixed the small detail checkpatch complained about)
Note, i've appended it to the timer tree for now - but for the lockdep bug we'll need another fix, and these two bugs will probably trigger a rebase. I'll leave it up to Thomas whether he wants to rebase the end result, once things have settled down.
Ingo
| ![\](/images/icornerr.gif) |