lkml.org 
[lkml]   [2009]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] Add minimal support for software performance counters for ia64
From
Date
On Wed, 2009-08-19 at 15:04 -0400, William Cohen wrote:
> Peter Zijlstra wrote:
> > On Wed, 2009-08-19 at 12:04 -0400, William Cohen wrote:
> >> +#ifdef __ia64__
> >> +#include "../../arch/ia64/include/asm/unistd.h"
> >> +#define rmb() asm volatile("" ::: "memory")
> >> +#define cpu_relax() asm volatile("" ::: "memory");
> >> +#endif
> >
> > Surely the itanic has a real memory barrier? The kernel seems to use
> > something along the lines of mf.
> >
> > Also, cpu_relax() seems to end up being asm volatile("hint @pause" :::
> > "memory"), although we don't seem to have an actual user of cpu_relax()
> > in perf atm.
> >
> >
> >
>
> Peter, thanks for the comment. I took a look at the rmb() and cpu_relax() code
> in the kernel and revised the patch with the appropriate defines

Looks good now, thanks!



\
 
 \ /
  Last update: 2009-08-19 21:09    [W:0.069 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site